fix ordering issue with relative rdatas

diff --git a/dns/dnssec.py b/dns/dnssec.py
index f09ecd60715c50964cead4d1fed6d4b824e07aa0..6e9946f4f344305c8c3f1a0ab8455c46e2b8da90 100644 (file)
--- a/dns/dnssec.py
+++ b/dns/dnssec.py
@@ -404,13 +404,13 @@ def _validate_rrsig(rrset, rrsig, keys, origin=None, now=None):
     rrnamebuf = rrname.to_digestable()
     rrfixed = struct.pack('!HHI', rdataset.rdtype, rdataset.rdclass,
                           rrsig.original_ttl)
-    for rr in sorted(rdataset):
+    rdatas = [rdata.to_digestable(origin) for rdata in rdataset]
+    for rdata in sorted(rdatas):
         data += rrnamebuf
         data += rrfixed
-        rrdata = rr.to_digestable(origin)
-        rrlen = struct.pack('!H', len(rrdata))
+        rrlen = struct.pack('!H', len(rdata))
         data += rrlen
-        data += rrdata
+        data += rdata
 
     chosen_hash = _make_hash(rrsig.algorithm)