]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
libstdc++: Add noexcept-specifier to std::reference_wrapper::operator()
authorJonathan Wakely <jwakely@redhat.com>
Wed, 31 Aug 2022 12:57:34 +0000 (13:57 +0100)
committerJonathan Wakely <jwakely@redhat.com>
Tue, 21 Feb 2023 00:48:05 +0000 (00:48 +0000)
This isn't required by the standard, but there's an LWG issue suggesting
to add it.

Also use __invoke_result instead of result_of, to match the spec in
recent standards.

libstdc++-v3/ChangeLog:

* include/bits/refwrap.h (reference_wrapper::operator()): Add
noexcept-specifier and use __invoke_result instead of result_of.
* testsuite/20_util/reference_wrapper/invoke-noexcept.cc: New test.

(cherry picked from commit e47df5eb56c4e7aca0d3e50826e5aaa1887fa446)

libstdc++-v3/include/bits/refwrap.h
libstdc++-v3/testsuite/20_util/reference_wrapper/invoke-noexcept.cc [new file with mode: 0644]

index 8016f87478eb436ca35b5422ef7a8fa12804d585..976902bc7bc430a01797497c80b02fe505391c67 100644 (file)
@@ -348,8 +348,9 @@ _GLIBCXX_MEM_FN_TRAITS(&& noexcept, false_type, true_type)
 
       template<typename... _Args>
        _GLIBCXX20_CONSTEXPR
-       typename result_of<_Tp&(_Args&&...)>::type
+       typename __invoke_result<_Tp&, _Args...>::type
        operator()(_Args&&... __args) const
+       noexcept(__is_nothrow_invocable<_Tp&, _Args...>::value)
        {
 #if __cplusplus > 201703L
          if constexpr (is_object_v<type>)
diff --git a/libstdc++-v3/testsuite/20_util/reference_wrapper/invoke-noexcept.cc b/libstdc++-v3/testsuite/20_util/reference_wrapper/invoke-noexcept.cc
new file mode 100644 (file)
index 0000000..91b5d09
--- /dev/null
@@ -0,0 +1,15 @@
+// { dg-do compile { target c++11 } }
+
+// C++11 20.8.3.4 reference_wrapper invocation [refwrap.invoke]
+
+#include <functional>
+
+struct F
+{
+  int operator()() noexcept(true) { return 1; }
+  int operator()() const noexcept(false) { return 2; }
+};
+
+F f;
+static_assert( noexcept(std::ref(f)()) );
+static_assert( ! noexcept(std::cref(f)()) );