]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
serial: 8250: longson: Fix NULL vs IS_ERR() bug in probe
authorDan Carpenter <dan.carpenter@linaro.org>
Sat, 29 Nov 2025 14:51:23 +0000 (17:51 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Dec 2025 14:11:00 +0000 (15:11 +0100)
The devm_platform_get_and_ioremap_resource() function never returns
NULL, it returns error pointers.  Fix the error checking to match.

Fixes: 25e95d763176 ("serial: 8250: Add Loongson uart driver support")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/aSsIa3KdAlXh5uQC@stanley.mountain
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_loongson.c

index 53153a116c011422c5c45b88fff91cc73be894a7..47df3c4c9d21f4cb67140ce95691dadfe6a30c69 100644 (file)
@@ -128,8 +128,8 @@ static int loongson_uart_probe(struct platform_device *pdev)
        port->private_data = priv;
 
        port->membase = devm_platform_get_and_ioremap_resource(pdev, 0, &priv->res);
-       if (!port->membase)
-               return -ENOMEM;
+       if (IS_ERR(port->membase))
+               return PTR_ERR(port->membase);
 
        port->mapbase = priv->res->start;
        port->mapsize = resource_size(priv->res);