]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: cec: extron-da-hd-4k-plus: Fix Wformat-truncation
authorHans Verkuil <hverkuil@xs4all.nl>
Tue, 1 Apr 2025 14:17:55 +0000 (14:17 +0000)
committerHans Verkuil <hverkuil@xs4all.nl>
Fri, 25 Apr 2025 13:14:30 +0000 (15:14 +0200)
Fix gcc8 warning:

drivers/media/cec/usb/extron-da-hd-4k-plus/extron-da-hd-4k-plus.c:1014:44: warning: 'DCEC' directive output may be truncated writing 4 bytes into a region of size between 0 and 53 [-Wformat-truncation=]

Resizing the 'buf' and 'cmd' arrays fixed the warning.

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/cec/usb/extron-da-hd-4k-plus/extron-da-hd-4k-plus.c

index cfbfc4c1b2e67fec9434aa6852ab465ad8c11225..41d019b01ec09d1d3e72c89155042888b7948463 100644 (file)
@@ -1002,8 +1002,8 @@ static int extron_cec_adap_transmit(struct cec_adapter *adap, u8 attempts,
                                    u32 signal_free_time, struct cec_msg *msg)
 {
        struct extron_port *port = cec_get_drvdata(adap);
-       char buf[CEC_MAX_MSG_SIZE * 3 + 1];
-       char cmd[CEC_MAX_MSG_SIZE * 3 + 13];
+       char buf[(CEC_MAX_MSG_SIZE - 1) * 3 + 1];
+       char cmd[sizeof(buf) + 14];
        unsigned int i;
 
        if (port->disconnected)