]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
btrfs: update target inode's ctime on unlink
authorJeff Layton <jlayton@kernel.org>
Mon, 12 Aug 2024 16:30:52 +0000 (12:30 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Sep 2024 17:24:05 +0000 (19:24 +0200)
[ Upstream commit 3bc2ac2f8f0b78a13140fc72022771efe0c9b778 ]

Unlink changes the link count on the target inode. POSIX mandates that
the ctime must also change when this occurs.

According to https://pubs.opengroup.org/onlinepubs/9699919799/functions/unlink.html:

"Upon successful completion, unlink() shall mark for update the last data
 modification and last file status change timestamps of the parent
 directory. Also, if the file's link count is not 0, the last file status
 change timestamp of the file shall be marked for update."

Signed-off-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: David Sterba <dsterba@suse.com>
[ add link to the opengroup docs ]
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/btrfs/inode.c

index a4223821188788c18e540d1f6ade08262f1a699e..ee04185d8e0f58e3160f72049d6acd557af1fa7a 100644 (file)
@@ -4148,6 +4148,7 @@ err:
 
        btrfs_i_size_write(dir, dir->vfs_inode.i_size - name->len * 2);
        inode_inc_iversion(&inode->vfs_inode);
+       inode_set_ctime_current(&inode->vfs_inode);
        inode_inc_iversion(&dir->vfs_inode);
        inode_set_ctime_current(&inode->vfs_inode);
        dir->vfs_inode.i_mtime = inode_set_ctime_current(&dir->vfs_inode);