]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drivers/block/rbd: Use strscpy() to copy strings into arrays
authorDavid Laight <david.laight.linux@gmail.com>
Sat, 6 Jun 2026 20:27:44 +0000 (21:27 +0100)
committerJens Axboe <axboe@kernel.dk>
Mon, 8 Jun 2026 13:45:56 +0000 (07:45 -0600)
Replacing strcpy() with strscpy() ensures than overflow of the target
buffer cannot happen.

Signed-off-by: David Laight <david.laight.linux@gmail.com>
Reviewed-by: Alex Elder <elder@riscstar.com>
Link: https://patch.msgid.link/20260606202744.5113-5-david.laight.linux@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/rbd.c

index 0a0b0a1af7691e8638cbac6e50b1bded00b56197..301d1faacdf2fdeaa32b6e83ac6b5f9ef6eb83d3 100644 (file)
@@ -3672,7 +3672,7 @@ static void __rbd_lock(struct rbd_device *rbd_dev, const char *cookie)
        struct rbd_client_id cid = rbd_get_cid(rbd_dev);
 
        rbd_dev->lock_state = RBD_LOCK_STATE_LOCKED;
-       strcpy(rbd_dev->lock_cookie, cookie);
+       strscpy(rbd_dev->lock_cookie, cookie);
        rbd_set_owner_cid(rbd_dev, &cid);
        queue_work(rbd_dev->task_wq, &rbd_dev->acquired_lock_work);
 }