Remove obsolete speculative insert cleanup in ReorderBuffer.

Commit 4daa140a2f introduced proper decoding for speculative aborts. As a
result, the internal state is guaranteed to be clean when a new
speculative insert is encountered. This patch removes the defensive
cleanup code that is no longer reachable.

Author: Antonin Houska <ah@cybertec.at>
Discussion: https://postgr.es/m/23256.1772702981@localhost

diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c
index 4c230bcc8e4811e6281995c59235b8920d24b24e..682d13c9f22f088888eced4592e1362def70812f 100644 (file)
--- a/src/backend/replication/logical/reorderbuffer.c
+++ b/src/backend/replication/logical/reorderbuffer.c
@@ -2447,12 +2447,8 @@ ReorderBufferProcessTXN(ReorderBuffer *rb, ReorderBufferTXN *txn,
                                         * CheckTableNotInUse() and locking.
                                         */
 
-                                       /* clear out a pending (and thus failed) speculation */
-                                       if (specinsert != NULL)
-                                       {
-                                               ReorderBufferFreeChange(rb, specinsert, true);
-                                               specinsert = NULL;
-                                       }
+                                       /* Previous speculative insertion must be aborted */
+                                       Assert(specinsert == NULL);
 
                                        /* and memorize the pending insertion */
                                        dlist_delete(&change->node);