Bug 577407: Several HTML elements have the same ID when editing parameters

r/a=mkanat

diff --git a/template/en/default/admin/params/attachment.html.tmpl b/template/en/default/admin/params/attachment.html.tmpl
index e6f6cb778d43048bcce52ef1ca2501c2076d3df8..12fd491fceb9c987cb0e849a4468e3b72b9702e3 100644 (file)
--- a/template/en/default/admin/params/attachment.html.tmpl
+++ b/template/en/default/admin/params/attachment.html.tmpl
@@ -45,7 +45,7 @@
     _ " That is, a different domain name that resolves to this exact"
     _ " same $terms.Bugzilla installation.</p>"
     _ "<p>Note that if you have set the"
-    _ " <a href=\"editparams.cgi?section=core#cookiedomain\"><tt>cookiedomain</tt>"
+    _ " <a href=\"editparams.cgi?section=advanced#cookiedomain_desc\"><tt>cookiedomain</tt>"
     _" parameter</a>, you should set <tt>attachment_base</tt> to use a"
     _ " domain that would <em>not</em> be matched by"
     _ " <tt>cookiedomain</tt>.</p>"

diff --git a/template/en/default/admin/params/common.html.tmpl b/template/en/default/admin/params/common.html.tmpl
index 870451ebc8453052959221c12a5f174a8d70b7ee..3ec38ca56de0df365b6efb158dd9b2e81f461255 100644 (file)
--- a/template/en/default/admin/params/common.html.tmpl
+++ b/template/en/default/admin/params/common.html.tmpl
@@ -28,7 +28,7 @@
 
 <dl>
   [% FOREACH param = panel.param_list %]
-    <dt id="[% param.name FILTER html %]">[% param.name FILTER html %]</dt>
+    <dt id="[% param.name FILTER html %]_desc">[% param.name FILTER html %]</dt>
     <dd>[% panel.param_descs.${param.name} FILTER none %]
       <p>
       [% IF param.type == "t" %]

diff --git a/template/en/default/admin/params/index.html.tmpl b/template/en/default/admin/params/index.html.tmpl
index 1629c8c6fdc88b90025046d9b6c5ced8018c6ac5..9f80245281367a33eaf081b6ea1e97f150e10d92 100644 (file)
--- a/template/en/default/admin/params/index.html.tmpl
+++ b/template/en/default/admin/params/index.html.tmpl
@@ -35,7 +35,7 @@
         <tr>
           <td>
             <a href="editparams.cgi?section=
-              [%- panel.name FILTER url_quote %]#[% param.name FILTER url_quote %]">
+              [%- panel.name FILTER url_quote %]#[% param.name FILTER url_quote %]_desc">
               [% param.name FILTER html %]</a>
           </td>    
           <td>

diff --git a/template/en/default/admin/params/radius.html.tmpl b/template/en/default/admin/params/radius.html.tmpl
index ef2282d452ae1a353e355b8559ce5c8a9b0ad1b9..f12e581b7df40880634b68e6583a7c368da351f1 100644 (file)
--- a/template/en/default/admin/params/radius.html.tmpl
+++ b/template/en/default/admin/params/radius.html.tmpl
@@ -26,13 +26,13 @@
                    "(e.g. <code>radius.company.com</code>, or " _
                    "<code>radius.company.com:portnum</code>).<br>" _
                    "Required only if " _
-                   "<a href=\"?section=auth#user_verify_class\">the " _
+                   "<a href=\"?section=auth#user_verify_class_desc\">the " _
                    "<code>user_verify_class</code> parameter</a> contains " _
                    "<code>RADIUS</code>.",
 
   RADIUS_secret => "Your RADIUS server's secret.<br>" _
                    "Required only if " _
-                   "<a href=\"?section=auth#user_verify_class\">the " _
+                   "<a href=\"?section=auth#user_verify_class_desc\">the " _
                    "<code>user_verify_class</code> parameter</a> contains " _
                    "<code>RADIUS</code>.",
 
@@ -40,14 +40,14 @@
                    "data with your RADIUS server. " _
                    "If unspecified, <code>127.0.0.1</code> will be used.<br>" _
                    "Useful only if " _
-                   "<a href=\"?section=auth#user_verify_class\">the " _
+                   "<a href=\"?section=auth#user_verify_class_desc\">the " _
                    "<code>user_verify_class</code> parameter</a> " _
                    "contains <code>RADIUS</code>.",
 
   RADIUS_email_suffix => "Suffix to append to a RADIUS user name to form an " _
                          "e-mail address.<br>" _
                          "Useful only if " _
-                         "<a href=\"?section=auth#user_verify_class\">the " _
+                         "<a href=\"?section=auth#user_verify_class_desc\">the " _
                          "<code>user_verify_class</code> parameter</a> " _
                          "contains <code>RADIUS</code>.",
   }

diff --git a/template/en/default/index.html.tmpl b/template/en/default/index.html.tmpl
index 4d760c6f81f394b43b5061bf1343e113944708ec..5e0de5d2d341edb7b134117bc32d559b69a58491 100644 (file)
--- a/template/en/default/index.html.tmpl
+++ b/template/en/default/index.html.tmpl
@@ -96,12 +96,12 @@ YAHOO.util.Event.onDOMReady(onLoadActions);
 
       <p class="notice">This message is only shown to logged in users with admin privs.
       You can configure this notification from the
-      <a href="editparams.cgi?section=general#upgrade_notification">Parameters</a> page.</p>
+      <a href="editparams.cgi?section=general#upgrade_notification_desc">Parameters</a> page.</p>
     [% ELSIF release.error == "cannot_download" %]
       <p>The local XML file '[% release.xml_file FILTER html %]' cannot be created.
       Please make sure the web server can write in this directory and that you can access
       the web. If you are behind a proxy, set the
-      <a href="editparams.cgi?section=core#proxy_url">proxy_url</a> parameter correctly.</p>
+      <a href="editparams.cgi?section=advanced#proxy_url_desc">proxy_url</a> parameter correctly.</p>
     [% ELSIF release.error == "no_update" %]
       <p>The local XML file '[% release.xml_file FILTER html %]' cannot be updated.
       Please make sure the web server can edit this file.</p>
@@ -114,7 +114,7 @@ YAHOO.util.Event.onDOMReady(onLoadActions);
     [% ELSIF release.error == "unknown_parameter" %]
       <p>'[% Param("upgrade_notification") FILTER html %]' is not a valid notification
       parameter. Please check this parameter in the
-      <a href="editparams.cgi?section=core#upgrade_notification">Parameters</a> page.</p>
+      <a href="editparams.cgi?section=general#upgrade_notification_desc">Parameters</a> page.</p>
     [% END %]
   </div>
 [% END %]

diff --git a/template/en/default/welcome-admin.html.tmpl b/template/en/default/welcome-admin.html.tmpl
index 3c03fb234cc8735db1bc5b11b88f533f645fd5ab..289a6bd7daf5ebde9eb73587dec75e23c80330e8 100644 (file)
--- a/template/en/default/welcome-admin.html.tmpl
+++ b/template/en/default/welcome-admin.html.tmpl
@@ -41,15 +41,15 @@
   parameters for this installation; among others:</p>
 
   <ul>
-    <li><a href="editparams.cgi?section=core#urlbase">urlbase</a>, which is the URL
+    <li><a href="editparams.cgi?section=core#urlbase_desc">urlbase</a>, which is the URL
     pointing to this installation and which will be used in emails (which is also the
     reason you see this page: as long as this parameter is not set, you will see this
     page again and again).</li>
 
-    <li><a href="editparams.cgi?section=core#cookiepath">cookiepath</a> is important
+    <li><a href="editparams.cgi?section=core#cookiepath_desc">cookiepath</a> is important
     for your browser to manage your cookies correctly.</li>
 
-    <li><a href="editparams.cgi?section=general#maintainer">maintainer</a>,
+    <li><a href="editparams.cgi?section=general#maintainer_desc">maintainer</a>,
       the person responsible for this installation if something is
       running wrongly.</li>
   </ul>
@@ -57,12 +57,12 @@
   <p>Also important are the following parameters:</p>
 
   <ul>
-    <li><a href="editparams.cgi?section=auth#requirelogin">requirelogin</a>, if turned
+    <li><a href="editparams.cgi?section=auth#requirelogin_desc">requirelogin</a>, if turned
     on, will protect your installation from users having no account on this installation.
     In other words, users who are not explicitly authenticated with a valid account
     cannot see any data. This is what you want if you want to keep your data private.</li>
 
-    <li><a href="editparams.cgi?section=auth#createemailregexp">createemailregexp</a>
+    <li><a href="editparams.cgi?section=auth#createemailregexp_desc">createemailregexp</a>
     defines which users are allowed to create an account on this installation. If set
     to ".*" (the default), everybody is free to create his own account. If set to
     "@mycompany.com$", only users having an account @mycompany.com will be allowed to
@@ -71,7 +71,7 @@
     installation, you must absolutely set this parameter to something different from
     the default.</li>
 
-    <li><a href="editparams.cgi?section=mta#mail_delivery_method">mail_delivery_method</a>
+    <li><a href="editparams.cgi?section=mta#mail_delivery_method_desc">mail_delivery_method</a>
     defines the method used to send emails, such as sendmail or SMTP. You have to set
     it correctly to send emails.</li>
   </ul>