]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
x86/efi: fix a -Wtype-limits compilation warning
authorQian Cai <cai@lca.pw>
Wed, 19 Jun 2019 17:47:44 +0000 (13:47 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 21 Jul 2019 07:01:56 +0000 (09:01 +0200)
[ Upstream commit 919aef44d73d5d0c04213cb1bc31149cc074e65e ]

Compiling a kernel with W=1 generates this warning,

arch/x86/platform/efi/quirks.c:731:16: warning: comparison of unsigned
expression >= 0 is always true [-Wtype-limits]

Fixes: 3425d934fc03 ("efi/x86: Handle page faults occurring while running ...")
Signed-off-by: Qian Cai <cai@lca.pw>
Acked-by: "Prakhya, Sai Praneeth" <sai.praneeth.prakhya@intel.com>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/x86/platform/efi/quirks.c

index a25a9fd987a9e5dc2ba75d7b3c91c098ad7d7034..529522c62d89fb146f6ce47ee31ea7dd03a2e641 100644 (file)
@@ -724,7 +724,7 @@ void efi_recover_from_page_fault(unsigned long phys_addr)
         * Address range 0x0000 - 0x0fff is always mapped in the efi_pgd, so
         * page faulting on these addresses isn't expected.
         */
-       if (phys_addr >= 0x0000 && phys_addr <= 0x0fff)
+       if (phys_addr <= 0x0fff)
                return;
 
        /*