]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
srvsvcd: Avoid an "else" due to the early return
authorVolker Lendecke <vl@samba.org>
Sun, 15 May 2022 11:20:34 +0000 (13:20 +0200)
committerJeremy Allison <jra@samba.org>
Fri, 20 May 2022 19:02:37 +0000 (19:02 +0000)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/rpc_server/srvsvc/srv_srvsvc_nt.c

index 21bb72670308c67d0b2802b41a0bfb5009cd78e6..20ac8ac0339684ad3bbd5dbb80a71a22452c95f5 100644 (file)
@@ -1970,13 +1970,13 @@ WERROR _srvsvc_NetShareSetInfo(struct pipes_struct *p,
                                     SHARE_1005_CSC_POLICY_MASK) >>
                                    SHARE_1005_CSC_POLICY_SHIFT;
 
-               if (client_csc_policy == lp_csc_policy(snum))
+               if (client_csc_policy == lp_csc_policy(snum)) {
                        return WERR_OK;
-               else {
-                       csc_policy = csc_policies[client_csc_policy];
-                       csc_policy_changed = true;
                }
 
+               csc_policy = csc_policies[client_csc_policy];
+               csc_policy_changed = true;
+
                pathname = lp_path(ctx, lp_sub, snum);
                comment = lp_comment(ctx, lp_sub, snum);
                type = STYPE_DISKTREE;