]> git.ipfire.org Git - thirdparty/xz.git/commitdiff
liblzma: Prevent uninitialzed warning in mt stream encoder.
authorJia Tan <jiat0218@gmail.com>
Wed, 28 Jun 2023 12:31:11 +0000 (20:31 +0800)
committerLasse Collin <lasse.collin@tukaani.org>
Tue, 7 May 2024 12:23:51 +0000 (15:23 +0300)
This change only impacts the compiler warning since it was impossible
for the wait_abs struct in stream_encode_mt() to be used before it was
initialized since mythread_condtime_set() will always be called before
mythread_cond_timedwait().

Since the mythread.h code is different between the POSIX and
Windows versions, this warning was only present on Windows builds.

Thanks to Arthur S for reporting the warning and providing an initial
patch.

(cherry picked from commit 1155471651ad456c5f90aee6435931fae65682bf)

src/liblzma/common/stream_encoder_mt.c

index 573a13b59595725b8fdb8341778c2ac19c3aa80a..3a4c345ce1ad64cedd23c4512bc4a82f54820df9 100644 (file)
@@ -692,7 +692,7 @@ stream_encode_mt(void *coder_ptr, const lzma_allocator *allocator,
 
                // These are for wait_for_work().
                bool has_blocked = false;
-               mythread_condtime wait_abs;
+               mythread_condtime wait_abs = { 0 };
 
                while (true) {
                        mythread_sync(coder->mutex) {