]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3: smbd: Add missing pop_sec_ctx() in error code path of close_directory()
authorJeremy Allison <jra@samba.org>
Wed, 12 Jan 2022 18:42:48 +0000 (10:42 -0800)
committerJeremy Allison <jra@samba.org>
Fri, 14 Jan 2022 03:34:47 +0000 (03:34 +0000)
If delete_all_streams() fails.

Found by Andrew Walker <awalker@ixsystems.com>

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14944

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Jan 14 03:34:47 UTC 2022 on sn-devel-184

source3/smbd/close.c

index 610450d086f67938b365a3756ad805d7d45a0df6..8abd3fb3861707d18c56e6d36b669e1aa4b14102 100644 (file)
@@ -1430,6 +1430,8 @@ static NTSTATUS close_directory(struct smb_request *req, files_struct *fsp,
                                DEBUG(5, ("delete_all_streams failed: %s\n",
                                          nt_errstr(status)));
                                file_free(req, fsp);
+                               /* unbecome user. */
+                               pop_sec_ctx();
                                return status;
                        }
                }