Switch from a global mutex

diff --git a/servers/lloadd/daemon.c b/servers/lloadd/daemon.c
index 1fe8c6d023b7a5e74d676191766fc6bd4c7eb384..77999b441e012b4f6b9b79b2555292bf4f5e5178 100644 (file)
--- a/servers/lloadd/daemon.c
+++ b/servers/lloadd/daemon.c
@@ -91,8 +91,6 @@ struct evdns_base *dnsbase;
 
 static int emfile;
 
-ldap_pvt_thread_mutex_t operation_mutex;
-
 static volatile int waking;
 #define WAKE_DAEMON( l, w ) \
     do { \
@@ -683,8 +681,6 @@ slapd_daemon_init( const char *urls )
     Debug( LDAP_DEBUG_ARGS, "slapd_daemon_init: %s\n",
             urls ? urls : "<null>" );
 
-    ldap_pvt_thread_mutex_init( &operation_mutex );
-
 #ifdef HAVE_TCPD
     ldap_pvt_thread_mutex_init( &sd_tcpd_mutex );
 #endif /* TCP Wrappers */

diff --git a/servers/lloadd/operation.c b/servers/lloadd/operation.c
index 14bf4bd7980b3d38034e1028eb584d0f30479118..bce5102a8ecefa09e7d5548903d49b04dfc639e0 100644 (file)
--- a/servers/lloadd/operation.c
+++ b/servers/lloadd/operation.c
@@ -174,9 +174,9 @@ operation_destroy_from_client( Operation *op )
     CONNECTION_UNLOCK_INCREF(client);
 
     if ( detach_client ) {
-        ldap_pvt_thread_mutex_lock( &operation_mutex );
+        ldap_pvt_thread_mutex_lock( &op->o_link_mutex );
         op->o_client = NULL;
-        ldap_pvt_thread_mutex_unlock( &operation_mutex );
+        ldap_pvt_thread_mutex_unlock( &op->o_link_mutex );
     }
 
     /* 4. If we lost the race, deal with it straight away */
@@ -211,14 +211,14 @@ operation_destroy_from_client( Operation *op )
     }
 
     /* 5. If we raced the upstream side and won, reclaim the token */
-    ldap_pvt_thread_mutex_lock( &operation_mutex );
+    ldap_pvt_thread_mutex_lock( &op->o_link_mutex );
     if ( !(race_state & SLAP_OP_DETACHING_UPSTREAM) ) {
         upstream = op->o_upstream;
         if ( upstream ) {
             CONNECTION_LOCK(upstream);
         }
     }
-    ldap_pvt_thread_mutex_unlock( &operation_mutex );
+    ldap_pvt_thread_mutex_unlock( &op->o_link_mutex );
 
     ldap_pvt_thread_mutex_lock( &op->o_mutex );
     /* We don't actually resolve the race in full until we grab the other's
@@ -286,6 +286,7 @@ operation_destroy_from_client( Operation *op )
             op, op->o_client_connid, op->o_client_msgid );
     ber_free( op->o_ber, 1 );
     ldap_pvt_thread_mutex_destroy( &op->o_mutex );
+    ldap_pvt_thread_mutex_destroy( &op->o_link_mutex );
     ch_free( op );
 
     CONNECTION_LOCK_DECREF(client);
@@ -334,11 +335,11 @@ operation_destroy_from_upstream( Operation *op )
     CONNECTION_UNLOCK_INCREF(upstream);
 
     /* 3. Detect whether we entered a race to free op */
-    ldap_pvt_thread_mutex_lock( &operation_mutex );
+    ldap_pvt_thread_mutex_lock( &op->o_link_mutex );
     if ( detach_upstream ) {
         op->o_upstream = NULL;
     }
-    ldap_pvt_thread_mutex_unlock( &operation_mutex );
+    ldap_pvt_thread_mutex_unlock( &op->o_link_mutex );
 
     if ( b ) {
         ldap_pvt_thread_mutex_lock( &b->b_mutex );
@@ -378,14 +379,14 @@ operation_destroy_from_upstream( Operation *op )
     }
 
     /* 5. If we raced the client side and won, reclaim the token */
-    ldap_pvt_thread_mutex_lock( &operation_mutex );
+    ldap_pvt_thread_mutex_lock( &op->o_link_mutex );
     if ( !(race_state & SLAP_OP_DETACHING_CLIENT) ) {
         client = op->o_client;
         if ( client ) {
             CONNECTION_LOCK(client);
         }
     }
-    ldap_pvt_thread_mutex_unlock( &operation_mutex );
+    ldap_pvt_thread_mutex_unlock( &op->o_link_mutex );
 
     /* We don't actually resolve the race in full until we grab the other's
      * c_mutex+op->o_mutex here */
@@ -443,6 +444,7 @@ operation_destroy_from_upstream( Operation *op )
             op, op->o_client_connid, op->o_client_msgid );
     ber_free( op->o_ber, 1 );
     ldap_pvt_thread_mutex_destroy( &op->o_mutex );
+    ldap_pvt_thread_mutex_destroy( &op->o_link_mutex );
     ch_free( op );
 
     CONNECTION_LOCK_DECREF(upstream);
@@ -465,6 +467,7 @@ operation_init( Connection *c, BerElement *ber )
     op->o_ber = ber;
 
     ldap_pvt_thread_mutex_init( &op->o_mutex );
+    ldap_pvt_thread_mutex_init( &op->o_link_mutex );
 
     op->o_client_live = op->o_client_refcnt = 1;
     op->o_upstream_live = op->o_upstream_refcnt = 1;
@@ -528,15 +531,15 @@ operation_abandon( Operation *op )
     Backend *b;
     int rc;
 
-    ldap_pvt_thread_mutex_lock( &operation_mutex );
+    ldap_pvt_thread_mutex_lock( &op->o_link_mutex );
     c = op->o_upstream;
     if ( !c ) {
-        ldap_pvt_thread_mutex_unlock( &operation_mutex );
+        ldap_pvt_thread_mutex_unlock( &op->o_link_mutex );
         goto done;
     }
 
     CONNECTION_LOCK(c);
-    ldap_pvt_thread_mutex_unlock( &operation_mutex );
+    ldap_pvt_thread_mutex_unlock( &op->o_link_mutex );
     if ( tavl_delete( &c->c_ops, op, operation_upstream_cmp ) == NULL ) {
         /* The operation has already been abandoned or finished */
         goto unlock;
@@ -669,7 +672,7 @@ operation_send_reject(
             "rejecting %s from client connid=%lu with message: \"%s\"\n",
             slap_msgtype2str( op->o_tag ), op->o_client_connid, msg );
 
-    ldap_pvt_thread_mutex_lock( &operation_mutex );
+    ldap_pvt_thread_mutex_lock( &op->o_link_mutex );
     c = op->o_client;
     if ( !c ) {
         c = op->o_upstream;
@@ -677,7 +680,7 @@ operation_send_reject(
          * client is dead, it must have been the upstream */
         assert( c );
         CONNECTION_LOCK(c);
-        ldap_pvt_thread_mutex_unlock( &operation_mutex );
+        ldap_pvt_thread_mutex_unlock( &op->o_link_mutex );
         Debug( LDAP_DEBUG_TRACE, "operation_send_reject: "
                 "not sending msgid=%d, client connid=%lu is dead\n",
                 op->o_client_msgid, op->o_client_connid );
@@ -686,7 +689,7 @@ operation_send_reject(
         return;
     }
     CONNECTION_LOCK(c);
-    ldap_pvt_thread_mutex_unlock( &operation_mutex );
+    ldap_pvt_thread_mutex_unlock( &op->o_link_mutex );
 
     found = ( tavl_delete( &c->c_ops, op, operation_client_cmp ) == op );
     if ( !found && !send_anyway ) {

diff --git a/servers/lloadd/proto-slap.h b/servers/lloadd/proto-slap.h
index e2463c5d9e97cb56bc7b46a3817e488cafce834d..cbdf9567f0911353dc30faff2407dfab63353ada 100644 (file)
--- a/servers/lloadd/proto-slap.h
+++ b/servers/lloadd/proto-slap.h
@@ -153,7 +153,6 @@ LDAP_SLAPD_V (const char *) slapd_slp_attrs;
 /*
  * operation.c
  */
-LDAP_SLAPD_V (ldap_pvt_thread_mutex_t) operation_mutex;
 LDAP_SLAPD_F (const char *) slap_msgtype2str( ber_tag_t tag );
 LDAP_SLAPD_F (int) operation_upstream_cmp( const void *l, const void *r );
 LDAP_SLAPD_F (int) operation_client_cmp( const void *l, const void *r );

diff --git a/servers/lloadd/slap.h b/servers/lloadd/slap.h
index 66d598b231749f9caf70792e7e5bb7c5f912c2cb..611266de62f02f490971038f56cc829ef8a03406 100644 (file)
--- a/servers/lloadd/slap.h
+++ b/servers/lloadd/slap.h
@@ -445,7 +445,13 @@ struct Operation {
     int o_upstream_live, o_upstream_refcnt;
     ber_int_t o_upstream_msgid;
 
+    /* Protects o_client, o_upstream pointers before we lock their c_mutex if
+     * we don't know they are still alive */
+    ldap_pvt_thread_mutex_t o_link_mutex;
+    /* Protects o_freeing, can be locked while holding c_mutex */
     ldap_pvt_thread_mutex_t o_mutex;
+    /* Consistent w.r.t. o_mutex, only written to while holding
+     * op->o_{client,upstream}->c_mutex */
     enum op_state o_freeing;
     ber_tag_t o_tag;
 

diff --git a/servers/lloadd/upstream.c b/servers/lloadd/upstream.c
index 70b0f0a7ce927131f1bf2c9dc1afaaf38fe11a39..8346db79367dc26e92ef8824e78be603b0d0e435 100644 (file)
--- a/servers/lloadd/upstream.c
+++ b/servers/lloadd/upstream.c
@@ -414,7 +414,7 @@ handle_one_response( Connection *c )
         op->o_upstream_refcnt++;
         CONNECTION_UNLOCK_INCREF(c);
 
-        ldap_pvt_thread_mutex_lock( &operation_mutex );
+        ldap_pvt_thread_mutex_lock( &op->o_link_mutex );
         client = op->o_client;
         if ( client ) {
             CONNECTION_LOCK(client);
@@ -426,7 +426,7 @@ handle_one_response( Connection *c )
                 client = NULL;
             }
         }
-        ldap_pvt_thread_mutex_unlock( &operation_mutex );
+        ldap_pvt_thread_mutex_unlock( &op->o_link_mutex );
 
         if ( client ) {
             rc = handler( op, ber );