vala: Variadic parameters are not supported for async methods

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 54392247e44c7d31138562dd076112010f364f28..6fbf66e463849aae6fa9950768d2daebf4c9f832 100644 (file)
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -356,6 +356,8 @@ TESTS = \
        asynchronous/closures.vala \
        asynchronous/generator.vala \
        asynchronous/result-pos.vala \
+       asynchronous/variadic-invalid.test \
+       asynchronous/variadic-invalid-2.test \
        asynchronous/yield.vala \
        generics/bug694765-1.vala \
        generics/bug694765-2.vala \

diff --git a/tests/asynchronous/variadic-invalid-2.test b/tests/asynchronous/variadic-invalid-2.test
new file mode 100644 (file)
index 0000000..cf4ee97
--- /dev/null
+++ b/tests/asynchronous/variadic-invalid-2.test
@@ -0,0 +1,7 @@
+Invalid Code
+
+async void foo (string first, va_list vals) {
+}
+
+void main () {
+}

diff --git a/tests/asynchronous/variadic-invalid.test b/tests/asynchronous/variadic-invalid.test
new file mode 100644 (file)
index 0000000..2e62113
--- /dev/null
+++ b/tests/asynchronous/variadic-invalid.test
@@ -0,0 +1,7 @@
+Invalid Code
+
+async void foo (string first, ...) {
+}
+
+void main () {
+}

diff --git a/vala/valamethod.vala b/vala/valamethod.vala
index 81ca7bb0dd5b84690b2f3201665d06029d9bb887..1d00d9460dad0b6f530aa9a939836f9d5f30ebdb 100644 (file)
--- a/vala/valamethod.vala
+++ b/vala/valamethod.vala
@@ -732,6 +732,11 @@ public class Vala.Method : Subroutine, Callable {
                                error = true;
                                Report.error (param.source_reference, "Reference parameters are not supported for async methods");
                        }
+                       if (!external_package && coroutine && (param.ellipsis || param.variable_type.data_type == context.analyzer.va_list_type.data_type)) {
+                               error = true;
+                               Report.error (param.source_reference, "Variadic parameters are not supported for async methods");
+                               return false;
+                       }
                        // TODO: begin and end parameters must be checked separately for coroutines
                        if (coroutine) {
                                continue;