]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
dns_common_replace: do logging in needs_add case
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Fri, 9 Apr 2021 10:50:24 +0000 (22:50 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Mon, 5 Jul 2021 04:16:34 +0000 (04:16 +0000)
The idiom is we return via goto exit.

This was evidently missed from commit
7e2b71d8f7cf7ac72022e1b15c30fc30706e8375

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/dns_server/dnsserver_common.c

index 30c1db6bee9d2ecdf774862071195d000ff79ed8..fb7ff32ce1821afea7cef08b6d2180a205f42304 100644 (file)
@@ -1055,7 +1055,7 @@ WERROR dns_common_replace(struct ldb_context *samdb,
                        goto exit;
                }
 
-               return WERR_OK;
+               werr = WERR_OK;
                goto exit;
        }