]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
phy: qcom: m31-eusb2: fix match data santity check
authorJohan Hovold <johan+linaro@kernel.org>
Tue, 17 Jun 2025 08:05:03 +0000 (10:05 +0200)
committerVinod Koul <vkoul@kernel.org>
Fri, 27 Jun 2025 00:10:12 +0000 (17:10 -0700)
The device_get_match_data() helper returns NULL if a new entry is ever
added without corresponding match data.

Fixes: 9c8504861cc4 ("phy: qcom: Add M31 based eUSB2 PHY driver")
Cc: Wesley Cheng <quic_wcheng@quicinc.com>
Cc: Melody Olvera <melody.olvera@oss.qualcomm.com>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20250617080503.11262-1-johan+linaro@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/qualcomm/phy-qcom-m31-eusb2.c

index 7b7120e4214f05762d674903673a42d7c14c3df2..520eabcc61f7100cf7e38505bcf7181f332bc831 100644 (file)
@@ -253,7 +253,7 @@ static int m31eusb2_phy_probe(struct platform_device *pdev)
                return -ENOMEM;
 
        data = device_get_match_data(dev);
-       if (IS_ERR(data))
+       if (!data)
                return -EINVAL;
        phy->data = data;