]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
audio/jack: Fix use of qemu_thread_set_name() on macOS
authorPhilippe Mathieu-Daudé <philmd@linaro.org>
Sat, 7 Mar 2026 11:37:35 +0000 (12:37 +0100)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Sun, 8 Mar 2026 22:11:14 +0000 (23:11 +0100)
Since commit 8f68a33ad46 we get on macOS:

  Audio backends
    CoreAudio support               : YES
    PipeWire support                : NO
    JACK support                    : YES 1.9.22

  ../audio/jackaudio.c:654:12: error: unused function 'qjack_thread_creator' [-Werror,-Wunused-function]
    654 | static int qjack_thread_creator(jack_native_thread_t *thread,
        |            ^~~~~~~~~~~~~~~~~~~~

This is simply due to a missing #ifdef'ry change. Update
so we can use the new qemu_thread_set_name() exposed by
commit 46255cc2be9.

Fixes: 8f68a33ad46 ("audio: make jackaudio use qemu_thread_set_name")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Message-Id: <20260307114923.75394-1-philmd@linaro.org>

audio/jackaudio.c

index be6fb378f72145e8d36f40e878e1b83654e10f65..589aecede9a2d7b987fedc6d73a004b858f4eae5 100644 (file)
@@ -712,7 +712,7 @@ static const TypeInfo audio_types[] = {
 static void __attribute__((__constructor__)) audio_jack_init(void)
 {
     qemu_mutex_init(&qjack_shutdown_lock);
-#if !defined(WIN32) && defined(CONFIG_PTHREAD_SETNAME_NP_W_TID)
+#if !defined(WIN32)
     jack_set_thread_creator(qjack_thread_creator);
 #endif
     jack_set_error_function(qjack_error);