]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
bnge: fix reserving resources from FW
authorVikas Gupta <vikas.gupta@broadcom.com>
Wed, 18 Feb 2026 05:27:55 +0000 (10:57 +0530)
committerJakub Kicinski <kuba@kernel.org>
Thu, 19 Feb 2026 17:29:59 +0000 (09:29 -0800)
HWRM_FUNC_CFG is used to reserve resources, whereas HWRM_FUNC_QCFG is
intended for querying resource information from the firmware.
Since __bnge_hwrm_reserve_pf_rings() reserves resources for a specific
PF, the command type should be HWRM_FUNC_CFG.

Fixes: 627c67f038d2 ("bng_en: Add resource management support")
Signed-off-by: Vikas Gupta <vikas.gupta@broadcom.com>
Reviewed-by: Bhargava Chenna Marreddy <bhargava.marreddy@broadcom.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20260218052755.4097468-1-vikas.gupta@broadcom.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c

index 84c90a95771905f43510387e96e0dc2d73f22d94..91a4ef9e3150bf144091e12f4a195f700c32bdc8 100644 (file)
@@ -442,7 +442,7 @@ __bnge_hwrm_reserve_pf_rings(struct bnge_dev *bd, struct bnge_hw_rings *hwr)
        struct hwrm_func_cfg_input *req;
        u32 enables = 0;
 
-       if (bnge_hwrm_req_init(bd, req, HWRM_FUNC_QCFG))
+       if (bnge_hwrm_req_init(bd, req, HWRM_FUNC_CFG))
                return NULL;
 
        req->fid = cpu_to_le16(0xffff);