]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Fix parsing of certificate validator responses (#452)
authorChristos Tsantilas <christos@chtsanti.net>
Fri, 9 Aug 2019 04:18:37 +0000 (04:18 +0000)
committerAmos Jeffries <yadij@users.noreply.github.com>
Sun, 8 Sep 2019 23:50:23 +0000 (11:50 +1200)
If a certificate validator did not end its response with an end-of-line
or whitespace character, then Squid, while parsing the response,
accessed the bytes after the end of the buffer where the response is
stored.

This is a Measurement Factory project.

src/ssl/cert_validate_message.cc

index f5bd8f44ae749a73b6160de3f3fc5eba625f5bd2..cabe62d89a5cd13bcb9b586b35d1ac31c5e17107 100644 (file)
@@ -149,7 +149,7 @@ Ssl::CertValidationMsg::parseResponse(CertValidationResponse &resp, STACK_OF(X50
             return false;
         }
 
-        param = value + value_len +1;
+        param = value + value_len;
     }
 
     /*Run through parsed errors to check for errors*/