]> git.ipfire.org Git - thirdparty/libcgroup.git/commitdiff
api.c: Fix string truncation warning
authorTom Hromatka <tom.hromatka@oracle.com>
Sun, 5 Jan 2020 22:26:47 +0000 (15:26 -0700)
committerTom Hromatka <tom.hromatka@oracle.com>
Wed, 8 Jan 2020 15:01:39 +0000 (08:01 -0700)
This commit fixes this warning in api.c:

api.c: In function ‘cgroup_delete_cgroup_ext’:
api.c:2285:51: warning: ‘snprintf’ output may be truncated before the
    last format character [-Wformat-truncation=]
    2285 |    snprintf(child_name, sizeof(child_name), "%s/%s",
         |                                                   ^
api.c:2285:4: note: ‘snprintf’ output 2 or more bytes (assuming 4097)
    into a destination of size 4096
    2285 |    snprintf(child_name, sizeof(child_name), "%s/%s",
         |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    2286 |      cgroup_name,
         |      ~~~~~~~~~~~~
    2287 |      info.full_path + group_len);
         |      ~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
src/api.c

index 5c347fadbd83aa1dba8a1142875634862e872a2e..30962fcccba657080f3022f984f4d34e86039866 100644 (file)
--- a/src/api.c
+++ b/src/api.c
@@ -2257,7 +2257,7 @@ static int cg_delete_cgroup_controller_recursive(char *cgroup_name,
        void *handle;
        struct cgroup_file_info info;
        int level, group_len;
-       char child_name[FILENAME_MAX];
+       char child_name[FILENAME_MAX + 1];
 
        cgroup_dbg("Recursively removing %s:%s\n", controller, cgroup_name);