Enable the `no-return-assign` rule.

diff --git a/js/.eslintrc.json b/js/.eslintrc.json
index fdca9c1dd2762fc1bebc2c88822463cd2a118f54..cc4e58ebd119821e37fc3eb319e5d88b6cd8e539 100644 (file)
--- a/js/.eslintrc.json
+++ b/js/.eslintrc.json
@@ -74,7 +74,7 @@
     "no-param-reassign": "off",
     "no-proto": "error",
     "no-restricted-properties": "error",
-    "no-return-assign": "off",
+    "no-return-assign": "error",
     "no-return-await": "error",
     "no-script-url": "error",
     "no-self-compare": "error",

diff --git a/js/src/popover.js b/js/src/popover.js
index 7639e3e2036894aa5ff1db412a1dc81badecd20a..f5820ecbed9bf0c26e71f9353e15b0f3ca650f6a 100644 (file)
--- a/js/src/popover.js
+++ b/js/src/popover.js
@@ -114,7 +114,8 @@ const Popover = (($) => {
     }
 
     getTipElement() {
-      return this.tip = this.tip || $(this.config.template)[0]
+      this.tip = this.tip || $(this.config.template)[0]
+      return this.tip
     }
 
     setContent() {

diff --git a/js/src/tooltip.js b/js/src/tooltip.js
index 721f0448187412bad5169da9c3dac1542a4c10de..7dfe9dfc03436cac551c3490b2218b71bef3ecab 100644 (file)
--- a/js/src/tooltip.js
+++ b/js/src/tooltip.js
@@ -415,7 +415,8 @@ const Tooltip = (($) => {
     }
 
     getTipElement() {
-      return this.tip = this.tip || $(this.config.template)[0]
+      this.tip = this.tip || $(this.config.template)[0]
+      return this.tip
     }
 
     setContent() {