python/samba: Avoid resource leak

View with 'git show -b'.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/python/samba/ms_display_specifiers.py b/python/samba/ms_display_specifiers.py
index be9891d74376e141bc405665113df1bfdb0b789c..ae48dce4ffbea510b1ed526739c1fa2e2090b0fc 100644 (file)
--- a/python/samba/ms_display_specifiers.py
+++ b/python/samba/ms_display_specifiers.py
@@ -176,9 +176,9 @@ def read_ms_ldif(filename):
     out = []
 
     from io import open
-    f = open(filename, "r", encoding='latin-1')
-    for entry in __read_raw_entries(f):
-        out.append(__write_ldif_one(__transform_entry(entry)))
+    with open(filename, "r", encoding='latin-1') as f:
+        for entry in __read_raw_entries(f):
+            out.append(__write_ldif_one(__transform_entry(entry)))
 
     return "\n\n".join(out) + "\n\n"