]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
RDMA/mana_ib: Fix error code in probe()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 7 Feb 2025 09:16:03 +0000 (12:16 +0300)
committerLeon Romanovsky <leon@kernel.org>
Sun, 9 Feb 2025 09:24:06 +0000 (04:24 -0500)
Return -ENOMEM if dma_pool_create() fails.  Don't return success.

Fixes: df91c470d9e5 ("RDMA/mana_ib: create/destroy AH")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/2bbe900e-18b3-46b5-a08c-42eb71886da6@stanley.mountain
Reviewed-by: Long Li <longli@microsoft.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/hw/mana/device.c

index 640a2c96b5ca03432cb1a31edf7ec19bed74a792..0c7a9929168f3f68ccb11c6fc9f663394f059abd 100644 (file)
@@ -151,8 +151,10 @@ static int mana_ib_probe(struct auxiliary_device *adev,
 
        dev->av_pool = dma_pool_create("mana_ib_av", mdev->gdma_context->dev,
                                       MANA_AV_BUFFER_SIZE, MANA_AV_BUFFER_SIZE, 0);
-       if (!dev->av_pool)
+       if (!dev->av_pool) {
+               ret = -ENOMEM;
                goto destroy_rnic;
+       }
 
        ret = ib_register_device(&dev->ib_dev, "mana_%d",
                                 mdev->gdma_context->dev);