]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
usb: typec: Use sysfs_emit_at when concatenating the string
authorKyle Tso <kyletso@google.com>
Fri, 23 Jun 2023 15:10:36 +0000 (23:10 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 25 Jul 2023 15:45:29 +0000 (17:45 +0200)
The buffer address used in sysfs_emit should be aligned to PAGE_SIZE.
Use sysfs_emit_at instead to offset the buffer.

Fixes: a7cff92f0635 ("usb: typec: USB Power Delivery helpers for ports and partners")
Cc: stable@vger.kernel.org
Signed-off-by: Kyle Tso <kyletso@google.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20230623151036.3955013-4-kyletso@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/class.c

index e7312295f8c9dc513c8f8d79a82c52c591d29378..9c1dbf3c00e0a7ee67679093ac22182e47660aa9 100644 (file)
@@ -1288,9 +1288,9 @@ static ssize_t select_usb_power_delivery_show(struct device *dev,
 
        for (i = 0; pds[i]; i++) {
                if (pds[i] == port->pd)
-                       ret += sysfs_emit(buf + ret, "[%s] ", dev_name(&pds[i]->dev));
+                       ret += sysfs_emit_at(buf, ret, "[%s] ", dev_name(&pds[i]->dev));
                else
-                       ret += sysfs_emit(buf + ret, "%s ", dev_name(&pds[i]->dev));
+                       ret += sysfs_emit_at(buf, ret, "%s ", dev_name(&pds[i]->dev));
        }
 
        buf[ret - 1] = '\n';