Landing fix for bug 153811: default severity should be parametrized.

r,a=myk.

diff --git a/defparams.pl b/defparams.pl
index ed6e6a0c7bc1549adb5ed0e0514cf6a3ac8e29c8..365bb7e3496f8a328ed0caeafda57851f5111590 100644 (file)
--- a/defparams.pl
+++ b/defparams.pl
@@ -66,6 +66,16 @@ sub check_priority {
     return "";
 }
 
+sub check_severity {
+    my ($value) = (@_);
+    &::GetVersionTable();
+    if (lsearch(\@::legal_severity, $value) < 0) {
+        return "Must be a legal severity value: one of " .
+            join(", ", @::legal_severity);
+    }
+    return "";
+}
+
 sub check_platform {
     my ($value) = (@_);
     &::GetVersionTable();
@@ -760,6 +770,14 @@ You will get this message once a day until you\'ve dealt with these bugs!
    checker => \&check_priority
   },
 
+  {
+   name => 'defaultseverity',
+   desc => 'This is the severity that newly entered bugs are set to.',
+   type => 't',
+   default => 'normal',
+   checker => \&check_severity
+  },
+
   {
     name => 'defaultplatform',
     desc => 'This is the platform that is preselected on the bug '.

diff --git a/enter_bug.cgi b/enter_bug.cgi
index a9f1f49583d7b9af6c51a81d6ccdc77c899391b7..c8ceed212e14f1438f0532894cde1b61cfa94a71 100755 (executable)
--- a/enter_bug.cgi
+++ b/enter_bug.cgi
@@ -327,7 +327,7 @@ $vars->{'priority'} = \@legal_priority;
 $default{'priority'} = formvalue('priority', Param('defaultpriority'));
 
 $vars->{'bug_severity'} = \@legal_severity;
-$default{'bug_severity'} = formvalue('bug_severity', 'normal');
+$default{'bug_severity'} = formvalue('bug_severity', Param('defaultseverity'));
 
 $vars->{'rep_platform'} = \@legal_platform;
 $default{'rep_platform'} = pickplatform();