]> git.ipfire.org Git - thirdparty/freeswitch.git/commitdiff
check return value of switch_vasprintf
authorMichael Jerris <mike@jerris.com>
Mon, 28 Apr 2014 13:54:20 +0000 (09:54 -0400)
committerMichael Jerris <mike@jerris.com>
Mon, 28 Apr 2014 13:54:20 +0000 (09:54 -0400)
src/switch_caller.c

index d9f6e46a020d864fccc7ae24a55d0efb13f64574..c36f599d93b828e582b26abf29a01243f2aa5cd9 100644 (file)
@@ -517,20 +517,17 @@ SWITCH_DECLARE(void) switch_caller_extension_add_application_printf(switch_core_
        char *data = NULL;
 
        va_start(ap, fmt);
-       switch_vasprintf(&data, fmt, ap);
-       va_end(ap);
-
-       if (!data) {
-               return;
-       }
-
-       if (strstr(data, "\\'")) {
-               switch_log_printf(SWITCH_CHANNEL_SESSION_LOG(session), SWITCH_LOG_WARNING, "App not added, Invalid character sequence in data string [%s]\n", data);
-       } else {
-               switch_caller_extension_add_application(session, caller_extension, application_name, data);
+       if ( switch_vasprintf(&data, fmt, ap) != -1 ) {
+               if (strstr(data, "\\'")) {
+                       switch_log_printf(SWITCH_CHANNEL_SESSION_LOG(session), SWITCH_LOG_WARNING, "App not added, Invalid character sequence in data string [%s]\n",
+                                                         data);
+               } else {
+                       switch_caller_extension_add_application(session, caller_extension, application_name, data);
+               }
        }
+       va_end(ap);
 
-       free(data);
+       switch_safe_free(data);
 }