Fix some problems with the bug9002 fix.

Fixes bug 9090; bug not in any released Tor.

diff --git a/src/or/rendcommon.c b/src/or/rendcommon.c
index 812fce973d27649f13b8b24bd2446076191cca33..76786e0fd112b8efabf16e63815397b88ac217b4 100644 (file)
--- a/src/or/rendcommon.c
+++ b/src/or/rendcommon.c
@@ -1081,6 +1081,7 @@ rend_cache_store(const char *desc, size_t desc_len, int published,
              "attempt to improve reliability, but it could also be an "
              "attempt to do a guard enumeration attack. Rejecting.",
              safe_str_client(query));
+    rend_service_descriptor_free(parsed);
     return -2;
   }
   tor_snprintf(key, sizeof(key), "0%s", query);
@@ -1336,6 +1337,8 @@ rend_cache_store_v2_desc_as_client(const char *desc,
                "attempt to improve reliability, but it could also be an "
                "attempt to do a guard enumeration attack. Rejecting.",
                safe_str_client(rend_query->onion_address));
+      retval = -2;
+      goto err;
     }
   } else {
     log_info(LD_REND, "Descriptor does not contain any introduction points.");