blkpr: prepare for _IOR() ioctls

parse_pr_command() returns the ioctl command constant for a given
command or -1 when the command is unknown. Up until now all ioctl
command constants were positive, so the following check worked:

  if (command < 0)
      err(EXIT_FAILURE, _("unknown command"));

The top two bits of ioctl command constants encode the direction (_IO,
_IOR, _IOW, _IOWR). ioctl commands defined with _IOR have negative ioctl
command constants.

Explicitly check for -1 to differentiate "unknown command" from valid
ioctls commands. Later commits will add ioctl commands that use _IOR.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

diff --git a/sys-utils/blkpr.c b/sys-utils/blkpr.c
index 03ca9f7e5fd1e97851aa588d306bfdce88ca9a8a..c6b030def38f2ab82bcf10e5cc80ccc10063a742 100644 (file)
--- a/sys-utils/blkpr.c
+++ b/sys-utils/blkpr.c
@@ -276,7 +276,7 @@ int main(int argc, char **argv)
                        break;
                case 'c':
                        command = parse_pr_command(optarg);
-                       if (command < 0)
+                       if (command == -1)
                                err(EXIT_FAILURE, _("unknown command"));
                        break;
                case 't':