]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
libcli/security: Remove unnecessary code
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Mon, 17 Jul 2023 03:48:50 +0000 (15:48 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 8 Aug 2023 04:39:36 +0000 (04:39 +0000)
The revision has already been set at the start of this function.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
libcli/security/sddl.c

index e14b2748384210561973b56eb23e31f4b1bfbb5d..022d20917b2ab2f14c0108b3829925d09f051de9 100644 (file)
@@ -587,16 +587,6 @@ static struct security_acl *sddl_decode_acl(struct security_descriptor *sd,
                        talloc_free(acl);
                        return NULL;
                }
-               switch (acl->aces[acl->num_aces].type) {
-               case SEC_ACE_TYPE_ACCESS_ALLOWED_OBJECT:
-               case SEC_ACE_TYPE_ACCESS_DENIED_OBJECT:
-               case SEC_ACE_TYPE_SYSTEM_AUDIT_OBJECT:
-               case SEC_ACE_TYPE_SYSTEM_ALARM_OBJECT:
-                       acl->revision = SECURITY_ACL_REVISION_ADS;
-                       break;
-               default:
-                       break;
-               }
                talloc_free(astr);
                sddl += len+2;
                acl->num_aces++;