]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
DECnet: don't leak uninitialized stack byte
authorDan Rosenberg <drosenberg@vsecurity.com>
Tue, 23 Nov 2010 11:02:13 +0000 (11:02 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 21 Mar 2011 19:44:08 +0000 (12:44 -0700)
commit 3c6f27bf33052ea6ba9d82369fb460726fb779c0 upstream.

A single uninitialized padding byte is leaked to userspace.

Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/decnet/af_decnet.c

index 2b494fac9468d6816a677a80d362cb28ffe18b41..7cc13e1c24797b78d69f8566982aef8b22cbb6ee 100644 (file)
@@ -1556,6 +1556,8 @@ static int __dn_getsockopt(struct socket *sock, int level,int optname, char __us
                        if (r_len > sizeof(struct linkinfo_dn))
                                r_len = sizeof(struct linkinfo_dn);
 
+                       memset(&link, 0, sizeof(link));
+
                        switch(sock->state) {
                                case SS_CONNECTING:
                                        link.idn_linkstate = LL_CONNECTING;