]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
We really do only need to set top_frame when pushing new things onto the stack
authorArran Cudbard-Bell <a.cudbardb@freeradius.org>
Tue, 10 Sep 2019 14:27:31 +0000 (09:27 -0500)
committerArran Cudbard-Bell <a.cudbardb@freeradius.org>
Tue, 10 Sep 2019 14:30:07 +0000 (09:30 -0500)
src/lib/unlang/interpret.c

index 4ce0cb6518a1b49d230b46a81bee8b5f28908c60..aca7964689369f1eea69753bf48ea0669fbe14f5 100644 (file)
@@ -258,22 +258,7 @@ void unlang_interpret_push(REQUEST *request, unlang_t *instruction,
        }
 
        frame->uflags = UNWIND_FLAG_NONE;
-
-       /*
-        *      Set flags which tell us when to stop.  Note that a top
-        *      frame *also* stops "break" and "return".
-        *
-        *      There's no real reason to have a top-frame stop
-        *      "break".  The compiler should already have caught it,
-        *      and complained about using "break" without an
-        *      enclosing "foreach".  But it's a useful check to have.
-        */
-       if (top_frame) {
-               top_frame_set(frame);
-               return_point_set(frame);
-               break_point_set(frame);
-       }
-
+       if (top_frame) top_frame_set(frame);
        frame->instruction = instruction;
        frame->result = default_rcode;
        frame->priority = -1;