]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
unswitch: Fix up one unguarded fprintf (dump_file, ...) [PR123736]
authorJakub Jelinek <jakub@redhat.com>
Thu, 22 Jan 2026 09:11:34 +0000 (10:11 +0100)
committerJakub Jelinek <jakub@gcc.gnu.org>
Thu, 22 Jan 2026 09:11:34 +0000 (10:11 +0100)
This dump message is not guarded on dump_file being non-NULL, so crashes
inside of libc if dump_file is NULL.

I think a message like that is usually guarded not just on dump_file
being non-NULL, but also on TDF_DETAILS set in dump_flags.

2026-01-22  Jakub Jelinek  <jakub@redhat.com>

PR tree-optimization/123736
* tree-ssa-loop-unswitch.cc (hoist_guard): Guard dump message
on dump_file && (dump_flags & TDF_DETAILS) condition.

gcc/tree-ssa-loop-unswitch.cc

index 7831a442851d2f87ff485e79b2e8d2a2b7becb2d..96680bc64ea37d7747095e0d81f77f2c63e4bc9e 100644 (file)
@@ -1459,7 +1459,8 @@ hoist_guard (class loop *loop, edge guard)
 
   if (skip_count > e->count ())
     {
-      fprintf (dump_file, "  Capping count; expect profile inconsistency\n");
+      if (dump_file && (dump_flags & TDF_DETAILS))
+       fprintf (dump_file, "  Capping count; expect profile inconsistency\n");
       skip_count = e->count ();
     }
   if (dump_enabled_p ())