]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
tests/docker: fix debian-all-test-cross
authorAlex Bennée <alex.bennee@linaro.org>
Mon, 4 Aug 2025 10:43:08 +0000 (11:43 +0100)
committerAlex Bennée <alex.bennee@linaro.org>
Mon, 4 Aug 2025 15:13:38 +0000 (16:13 +0100)
It turns out you can't easily expand an ENV var across multiple steps
in a dockerfile. This meant we silently dropped the architectures we
should have even on amd64 hosts. As the updated AVAILABLE_COMPILERS is
only needed for the following apt install line just merge them.

Fixes: 6da616bb170 (tests/docker: handle host-arch selection for all-test-cross)
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-ID: <20250804104308.250949-1-alex.bennee@linaro.org>

tests/docker/dockerfiles/debian-all-test-cross.docker

index ef69bbc8a518ac5bdedc46de9a84bbf7e1446626..420a4e33e608715a794beb45171fff7a43ce3e50 100644 (file)
@@ -62,9 +62,7 @@ RUN if dpkg-architecture -e amd64; then \
   export AVAILABLE_COMPILERS="${AVAILABLE_COMPILERS} gcc-powerpc64-linux-gnu libc6-dev-ppc64-cross"; \
   export AVAILABLE_COMPILERS="${AVAILABLE_COMPILERS} gcc-sparc64-linux-gnu libc6-dev-sparc64-cross"; \
   fi && \
-  echo "compilers: ${AVAILABLE_COMPILERS}"
-
-RUN DEBIAN_FRONTEND=noninteractive eatmydata \
+  DEBIAN_FRONTEND=noninteractive eatmydata \
         apt install -y --no-install-recommends \
         ${AVAILABLE_COMPILERS} && \
         dpkg-query --showformat '${Package}_${Version}_${Architecture}\n' --show > /packages.txt