zlibWrapper: support for stricter gcc warnings

diff --git a/zlibWrapper/Makefile b/zlibWrapper/Makefile
index 6c00622b02507f2d9c24007876daba677826cafb..962f92941c64535876219c143841a6fd251bcc05 100644 (file)
--- a/zlibWrapper/Makefile
+++ b/zlibWrapper/Makefile
@@ -18,7 +18,8 @@ endif
 ZLIBWRAPPER_PATH = .
 EXAMPLE_PATH = examples
 CC = gcc
-CFLAGS = $(LOC) -I../lib/common -I$(ZLIBDIR) -I$(ZLIBWRAPPER_PATH) -O3 -Wall -std=gnu89
+CFLAGS = $(LOC) -I../lib/common -I$(ZLIBDIR) -I$(ZLIBWRAPPER_PATH) -O3 -std=gnu90
+CFLAGS += -Wall -Wextra -Wcast-qual -Wcast-align -Wshadow -Wswitch-enum -Wstrict-prototypes -Wundef
 LDFLAGS = $(LOC)
 RM = rm -f
 

diff --git a/zlibWrapper/examples/example.c b/zlibWrapper/examples/example.c
index 3fea9d2ad72ccfe85d315b691b371f7a9c2b45c8..a2836cdbf5ce170456fd56f7ab8271c49d17bab9 100644 (file)
--- a/zlibWrapper/examples/example.c
+++ b/zlibWrapper/examples/example.c
@@ -61,8 +61,8 @@ void *myalloc(q, n, m)
     void *q;
     unsigned n, m;
 {
-    q = Z_NULL;
     void *buf = calloc(n, m);
+    q = Z_NULL;
   /*  printf("myalloc %p n=%d m=%d\n", buf, n, m); */
     return buf;
 }

diff --git a/zlibWrapper/zstd_zlibwrapper.c b/zlibWrapper/zstd_zlibwrapper.c
index b55b760afa321701051e96d66bb861af80ef6f8f..4740e0dbd3456314332a0fd3addbc305a632a41a 100644 (file)
--- a/zlibWrapper/zstd_zlibwrapper.c
+++ b/zlibWrapper/zstd_zlibwrapper.c
@@ -69,9 +69,9 @@ static int g_useZSTD = ZWRAP_USE_ZSTD;   /* 0 = don't use ZSTD */
 
 void useZSTD(int turn_on) { g_useZSTD = turn_on; }
 
-int isUsingZSTD() { return g_useZSTD; }
+int isUsingZSTD(void) { return g_useZSTD; }
 
-const char * zstdVersion() { return ZSTD_VERSION_STRING; }
+const char * zstdVersion(void) { return ZSTD_VERSION_STRING; }
 
 ZEXTERN const char * ZEXPORT z_zlibVersion OF((void)) { return zlibVersion();  }
 
@@ -421,8 +421,8 @@ ZEXTERN int ZEXPORT z_inflate OF((z_streamp strm, int flush))
                 strm->avail_out = strm2.avail_out;
 
                 strm->reserved = 0; /* mark as zlib stream */
-                { size_t const errorCode = ZWRAP_freeDCtx(zwd);
-                  if (ZSTD_isError(errorCode)) return Z_MEM_ERROR; }
+                errorCode = ZWRAP_freeDCtx(zwd);
+                if (ZSTD_isError(errorCode)) return Z_MEM_ERROR;
 
                 if (flush == Z_INFLATE_SYNC) return inflateSync(strm);
                 return inflate(strm, flush);
@@ -434,8 +434,8 @@ ZEXTERN int ZEXPORT z_inflate OF((z_streamp strm, int flush))
             } else
                zwd->zbd = ZBUFF_createDCtx();
 
-            { size_t const errorCode = ZBUFF_decompressInit(zwd->zbd);
-              if (ZSTD_isError(errorCode)) return Z_MEM_ERROR; }
+            errorCode = ZBUFF_decompressInit(zwd->zbd);
+            if (ZSTD_isError(errorCode)) return Z_MEM_ERROR;
 
             srcSize = ZWRAP_HEADERSIZE;
             dstCapacity = 0;

diff --git a/zlibWrapper/zstd_zlibwrapper.h b/zlibWrapper/zstd_zlibwrapper.h
index e438789acc9a6d59339c016f6d4047b4a6f9389b..d14c3a92a25f5ec491edaa20a747a3803bf98c95 100644 (file)
--- a/zlibWrapper/zstd_zlibwrapper.h
+++ b/zlibWrapper/zstd_zlibwrapper.h
@@ -49,8 +49,8 @@ extern "C" {
 #endif
 
 void useZSTD(int turn_on);
-int isUsingZSTD();
-const char * zstdVersion();
+int isUsingZSTD(void);
+const char * zstdVersion(void);
 
 
 #if defined (__cplusplus)