s4:libcli: Check return value of convert_string_talloc() (CID 1272839)

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/source4/libcli/ldap/ldap_controls.c b/source4/libcli/ldap/ldap_controls.c
index aee68ab2022aba92aa74590c00c89b39fa54e5ec..f8d82bab839506ee55544e023113e80a2b5a04df 100644 (file)
--- a/source4/libcli/ldap/ldap_controls.c
+++ b/source4/libcli/ldap/ldap_controls.c
@@ -499,9 +499,14 @@ static bool encode_verify_name_request(void *mem_ctx, void *in, DATA_BLOB *out)
        }
 
        if (lvnc->gc_len) {
-               convert_string_talloc(mem_ctx, CH_UNIX, CH_UTF16,
-                                               lvnc->gc, lvnc->gc_len,
-                                               &gc_utf16.data, &gc_utf16.length);
+               bool ok;
+
+               ok = convert_string_talloc(mem_ctx, CH_UNIX, CH_UTF16,
+                                          lvnc->gc, lvnc->gc_len,
+                                          &gc_utf16.data, &gc_utf16.length);
+               if (!ok) {
+                       return false;
+               }
                if (!asn1_write_OctetString(data, gc_utf16.data, gc_utf16.length)) {
                        return false;
                }