]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
mmc: sdhci-esdhc-imx: fix few build warnings
authorHaibo Chen <haibo.chen@nxp.com>
Fri, 16 May 2025 07:46:23 +0000 (15:46 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 19 May 2025 12:02:48 +0000 (14:02 +0200)
drivers/mmc/host/sdhci-esdhc-imx.c:1566 sdhci_esdhc_imx_hwinit() warn: inconsistent indenting
drivers/mmc/host/sdhci-esdhc-imx.c:1251 esdhc_executing_tuning() error: uninitialized symbol 'target_min'.
drivers/mmc/host/sdhci-esdhc-imx.c:1251 esdhc_executing_tuning() error: uninitialized symbol 'target_max'.

Fixes: be953af79cc6 ("mmc: sdhci-esdhc-imx: widen auto-tuning window for standard tuning")
Fixes: 541a95e64d76 ("mmc: sdhci-esdhc-imx: optimize the manual tuing logic to get the best timing")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/all/202505160225.Csr5USfq-lkp@intel.com/
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
Link: https://lore.kernel.org/r/20250516-b4-usdhc-v2-1-3fccd02f5602@nxp.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci-esdhc-imx.c

index 7611682f10c3ba0e8f7a851791a375c927b56dde..ac187a8798b710afa8bc1db8d724b4355a6cbdef 100644 (file)
@@ -1216,8 +1216,8 @@ static int esdhc_executing_tuning(struct sdhci_host *host, u32 opcode)
        int win_length, target_min, target_max, target_win_length;
        u32 clk_tune_ctrl_status, temp;
 
-       min = ESDHC_TUNE_CTRL_MIN;
-       max = ESDHC_TUNE_CTRL_MIN;
+       min = target_min = ESDHC_TUNE_CTRL_MIN;
+       max = target_max = ESDHC_TUNE_CTRL_MIN;
        target_win_length = 0;
        while (max < ESDHC_TUNE_CTRL_MAX) {
                /* find the mininum delay first which can pass tuning */
@@ -1591,8 +1591,8 @@ static void sdhci_esdhc_imx_hwinit(struct sdhci_host *host)
                         * wider, give auto tuning enough space to handle the sample
                         * point shift cause by temperature change.
                         */
-                        tmp &= ~ESDHC_TUNING_WINDOW_MASK;
-                        tmp |= FIELD_PREP(ESDHC_TUNING_WINDOW_MASK, ESDHC_AUTO_TUNING_WINDOW);
+                       tmp &= ~ESDHC_TUNING_WINDOW_MASK;
+                       tmp |= FIELD_PREP(ESDHC_TUNING_WINDOW_MASK, ESDHC_AUTO_TUNING_WINDOW);
 
                        /* Disable the CMD CRC check for tuning, if not, need to
                         * add some delay after every tuning command, because