]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: ltr501: ltr501_read_ps(): add missing endianness conversion
authorOliver Lang <Oliver.Lang@gossenmetrawatt.com>
Thu, 10 Jun 2021 13:46:18 +0000 (15:46 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Jul 2021 14:22:31 +0000 (16:22 +0200)
commit 71b33f6f93ef9462c84560e2236ed22209d26a58 upstream.

The PS ADC Channel data is spread over 2 registers in little-endian
form. This patch adds the missing endianness conversion.

Fixes: 2690be905123 ("iio: Add Lite-On ltr501 ambient light / proximity sensor driver")
Signed-off-by: Oliver Lang <Oliver.Lang@gossenmetrawatt.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Tested-by: Nikita Travkin <nikita@trvn.ru> # ltr559
Link: https://lore.kernel.org/r/20210610134619.2101372-4-mkl@pengutronix.de
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iio/light/ltr501.c

index da9c7cbca89fa348c4fec329d8b2fe0f9a44aafb..111552b336fe04f806ee59185a72026580000bb3 100644 (file)
@@ -411,18 +411,19 @@ static int ltr501_read_als(struct ltr501_data *data, __le16 buf[2])
 
 static int ltr501_read_ps(struct ltr501_data *data)
 {
-       int ret, status;
+       __le16 status;
+       int ret;
 
        ret = ltr501_drdy(data, LTR501_STATUS_PS_RDY);
        if (ret < 0)
                return ret;
 
        ret = regmap_bulk_read(data->regmap, LTR501_PS_DATA,
-                              &status, 2);
+                              &status, sizeof(status));
        if (ret < 0)
                return ret;
 
-       return status;
+       return le16_to_cpu(status);
 }
 
 static int ltr501_read_intr_prst(struct ltr501_data *data,