submodule--helper: fix "errmsg_str" memory leak

Fix a memory leak introduced in e83e3333b57 (submodule: port submodule
subcommand 'summary' from shell to C, 2020-08-13), we sometimes append
to the "errmsg", and need to free the "struct strbuf".

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Reviewed-by: Glen Choo <chooglen@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 65cd25a25119137d2bf0aa9b5e5086f4434f7197..c95098e62155816afbb58af9e27802964ba967d7 100644 (file)
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -973,6 +973,7 @@ static void generate_submodule_summary(struct summary_cb *info,
        free(displaypath);
        free(src_abbrev);
        free(dst_abbrev);
+       strbuf_release(&errmsg);
 }
 
 static void prepare_submodule_summary(struct summary_cb *info,