]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/panel: mantix: Improve power off sequence
authorSebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Mon, 5 Jan 2026 20:24:42 +0000 (21:24 +0100)
committerNeil Armstrong <neil.armstrong@linaro.org>
Tue, 13 Jan 2026 08:53:12 +0000 (09:53 +0100)
According to the sequence from section 7.3.4 of FT8006P datasheet,
TP_RSTN and RESX should be asserted after disabling AVDD and AVEE and
together with VDDI.

Also, AVEE power down needs to happen at least 150ms after entering
sleep mode.

Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patch.msgid.link/20260105-mantix-halo-fixes-v1-3-1ebc9b195a34@puri.sm
drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c

index bb5489e4d7a93fa84412409b5f03090a169abc50..0e66ee7a727d229c839f14239a36dd43fc73adff 100644 (file)
@@ -96,6 +96,9 @@ static int mantix_disable(struct drm_panel *panel)
        mipi_dsi_dcs_set_display_off_multi(&dsi_ctx);
        mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx);
 
+       /* T10 */
+       mipi_dsi_msleep(&dsi_ctx, 150);
+
        return dsi_ctx.accum_err;
 }
 
@@ -103,15 +106,16 @@ static int mantix_unprepare(struct drm_panel *panel)
 {
        struct mantix *ctx = panel_to_mantix(panel);
 
-       gpiod_set_value_cansleep(ctx->tp_rstn_gpio, 1);
-       usleep_range(5000, 6000);
-       gpiod_set_value_cansleep(ctx->reset_gpio, 1);
-
        regulator_disable(ctx->avee);
        regulator_disable(ctx->avdd);
        /* T11 */
        usleep_range(5000, 6000);
        regulator_disable(ctx->vddi);
+
+       gpiod_set_value_cansleep(ctx->tp_rstn_gpio, 1);
+       usleep_range(5000, 6000);
+       gpiod_set_value_cansleep(ctx->reset_gpio, 1);
+
        /* T14 */
        msleep(50);