selftest: move knownfail.d/krb5-no-dollar to expectedfail.d

If these fail to fail, there is a problem.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>

diff --git a/selftest/knownfail.d/krb5-no-dollar b/selftest/expectedfail.d/krb5-no-dollar
similarity index 76%
rename from selftest/knownfail.d/krb5-no-dollar
rename to selftest/expectedfail.d/krb5-no-dollar
index 4c417779a692767edf692ae5ee5e6ac9336f705a..53acc75dab1cbc661e5d61b7577ca5102b366dac 100644 (file)
--- a/selftest/knownfail.d/krb5-no-dollar
+++ b/selftest/expectedfail.d/krb5-no-dollar
@@ -1,4 +1,14 @@
+# We expect some Kerberos name matching tests to fail in the
+# ad_dc_ntvfs environment, because it has
+#
+#  kdc name match implicit dollar without canonicalization = no
+#
+# set, meaning tests that assert 'foo' matches 'foo$' in principal
+# lookups will fail.
+
 ^samba4\.krb5\.kdc\ with\ machine\ account\ no\ dollar\ extension\.canon\.canon\.enterprise\.lc\-user\.no\-win2k\.removedollar\.s4u2self\.canon\.enterprise\.lc\-user\.no\-win2k\.removedollar\.s4u2self\(ad_dc_ntvfs:local\)
 ^samba4\.krb5\.kdc\ with\ machine\ account\ no\ dollar\ extension\.canon\.canon\.enterprise\.uc\-user\.no\-win2k\.removedollar\.s4u2self\.canon\.enterprise\.uc\-user\.no\-win2k\.removedollar\.s4u2self\(ad_dc_ntvfs:local\)
+
+
 ^samba4\.krb5\.kdc\ with\ machine\ account\ no\ dollar\ extension\.canon\.canon\.enterprise\.lc\-user\.win2k\.removedollar\.s4u2self\.canon\.enterprise\.lc\-user\.win2k\.removedollar\.s4u2self\(ad_dc_ntvfs:local\)
 ^samba4\.krb5\.kdc\ with\ machine\ account\ no\ dollar\ extension\.canon\.canon\.enterprise\.uc\-user\.win2k\.removedollar\.s4u2self\.canon\.enterprise\.uc\-user\.win2k\.removedollar\.s4u2self\(ad_dc_ntvfs:local\)