]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: phy: phy_port: Cleanup the of-parsing logic for phy_port
authorMaxime Chevallier <maxime.chevallier@bootlin.com>
Thu, 5 Feb 2026 09:23:05 +0000 (10:23 +0100)
committerJakub Kicinski <kuba@kernel.org>
Fri, 13 Feb 2026 01:44:55 +0000 (17:44 -0800)
We don't need to maintain a mediums bitfield, let's drop it and drop a
bogus check for empty mediums, as we already check it above.

Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Reviewed-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>
Link: https://patch.msgid.link/20260205092317.755906-3-maxime.chevallier@bootlin.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/phy_port.c

index ec93c8ca051e827ac6c643e4eb1011d074a28e74..a269e9ea12c43fbe46bd14ae6b7ad2b006945214 100644 (file)
@@ -53,7 +53,7 @@ struct phy_port *phy_of_parse_port(struct device_node *dn)
        enum ethtool_link_medium medium;
        struct phy_port *port;
        const char *med_str;
-       u32 pairs = 0, mediums = 0;
+       u32 pairs = 0;
        int ret;
 
        ret = fwnode_property_read_string(fwnode, "media", &med_str);
@@ -85,17 +85,12 @@ struct phy_port *phy_of_parse_port(struct device_node *dn)
                return ERR_PTR(-EINVAL);
        }
 
-       mediums |= BIT(medium);
-
-       if (!mediums)
-               return ERR_PTR(-EINVAL);
-
        port = phy_port_alloc();
        if (!port)
                return ERR_PTR(-ENOMEM);
 
        port->pairs = pairs;
-       port->mediums = mediums;
+       port->mediums = BIT(medium);
 
        return port;
 }