]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: rtw88: usb: Remove redundant 'flush_workqueue()' calls
authorChen Ni <nichen@iscas.ac.cn>
Mon, 24 Mar 2025 08:03:03 +0000 (16:03 +0800)
committerPing-Ke Shih <pkshih@realtek.com>
Mon, 31 Mar 2025 06:41:38 +0000 (14:41 +0800)
'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.

Remove the redundant 'flush_workqueue()' calls.

This was generated with coccinelle:

@@
expression E;
@@

- flush_workqueue(E);
  destroy_workqueue(E);

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/20250324080303.408084-1-nichen@iscas.ac.cn
drivers/net/wireless/realtek/rtw88/usb.c

index c8092fa0d9f13de59c2fc39ddb522b798084bf44..667473b7a9f5c1fe26a4c606586fa1624209c85a 100644 (file)
@@ -948,7 +948,6 @@ static void rtw_usb_deinit_rx(struct rtw_dev *rtwdev)
 
        skb_queue_purge(&rtwusb->rx_queue);
 
-       flush_workqueue(rtwusb->rxwq);
        destroy_workqueue(rtwusb->rxwq);
 
        skb_queue_purge(&rtwusb->rx_free_queue);
@@ -977,7 +976,6 @@ static void rtw_usb_deinit_tx(struct rtw_dev *rtwdev)
 {
        struct rtw_usb *rtwusb = rtw_get_usb_priv(rtwdev);
 
-       flush_workqueue(rtwusb->txwq);
        destroy_workqueue(rtwusb->txwq);
        rtw_usb_tx_queue_purge(rtwusb);
 }