]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
char: misc: Rename a local variable in misc_init()
authorZijun Hu <zijun.hu@oss.qualcomm.com>
Wed, 25 Jun 2025 13:53:20 +0000 (21:53 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 1 Jul 2025 10:29:52 +0000 (12:29 +0200)
Local variable @ret is not used for return value in misc_init().

Give it a different name @misc_proc_file.

Signed-off-by: Zijun Hu <zijun.hu@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250625-fix_mischar-v2-1-25a80f41b090@oss.qualcomm.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/misc.c

index 5247d0ec0f4c5363d5ecd2881741510158295779..558302a64dd908aee30341547a5413df1af71459 100644 (file)
@@ -289,9 +289,9 @@ EXPORT_SYMBOL(misc_deregister);
 static int __init misc_init(void)
 {
        int err;
-       struct proc_dir_entry *ret;
+       struct proc_dir_entry *misc_proc_file;
 
-       ret = proc_create_seq("misc", 0, NULL, &misc_seq_ops);
+       misc_proc_file = proc_create_seq("misc", 0, NULL, &misc_seq_ops);
        err = class_register(&misc_class);
        if (err)
                goto fail_remove;
@@ -305,7 +305,7 @@ fail_printk:
        pr_err("unable to get major %d for misc devices\n", MISC_MAJOR);
        class_unregister(&misc_class);
 fail_remove:
-       if (ret)
+       if (misc_proc_file)
                remove_proc_entry("misc", NULL);
        return err;
 }