s4:cracknames: initialise a string variable

because later we go

	ret = krb5_unparse_name_flags([...],
				      &unparsed_name_short);
	if (ret) {
		free(unparsed_name_short);
		return WERR_NOT_ENOUGH_MEMORY;
	}

which is bad if a krb5_unparse_name_flags() errors without setting
unparsed_name_short -- not that I see that happening in MIT or Heimdal.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>

diff --git a/source4/dsdb/samdb/cracknames.c b/source4/dsdb/samdb/cracknames.c
index c04d4aed572388de31d074a3da01b5f5c50015cd..c1066e269a14e6aa40767665833e7d225959d655 100644 (file)
--- a/source4/dsdb/samdb/cracknames.c
+++ b/source4/dsdb/samdb/cracknames.c
@@ -286,7 +286,7 @@ static WERROR DsCrackNameUPN(struct ldb_context *sam_ctx, TALLOC_CTX *mem_ctx,
        krb5_principal principal;
        char *realm;
        char *realm_encoded = NULL;
-       char *unparsed_name_short;
+       char *unparsed_name_short = NULL;
        const char *unparsed_name_short_encoded = NULL;
        const char *domain_attrs[] = { NULL };
        struct ldb_result *domain_res = NULL;