]> git.ipfire.org Git - thirdparty/kea.git/commitdiff
[#2538] Addressed more comments
authorThomas Markwalder <tmark@isc.org>
Thu, 9 Feb 2023 20:09:04 +0000 (15:09 -0500)
committerThomas Markwalder <tmark@isc.org>
Thu, 9 Feb 2023 21:26:45 +0000 (16:26 -0500)
src/lib/dhcp/option.cc
    Removed dead line

src/lib/dhcpsrv/tests/host_reservation_parser_unittest.cc
    Removed unneeded include

src/lib/dhcp/option.cc
src/lib/dhcpsrv/tests/host_reservation_parser_unittest.cc

index b50df37601cc77a9c763b4730182cbfa820e0877..5b95dac699a6dafb0d575b2aab70485950dfe6a3 100644 (file)
@@ -333,7 +333,6 @@ void Option::addOption(OptionPtr opt) {
         // Do not allow options to be added to themselves as this
         // can lead to infinite recursion.
         isc_throw(InvalidOperation, "option cannot be added to itself: " << toText());
-        // return;
     }
 
     options_.insert(make_pair(opt->getType(), opt));
index b79a032bccc582c6ba24c2f1aa775807cc15f810..a7c1de49e0e90583b5e453ece21a80add27c5268 100644 (file)
@@ -10,7 +10,6 @@
 #include <cc/data.h>
 #include <dhcp/duid.h>
 #include <dhcp/hwaddr.h>
-#include <dhcp/option_custom.h>
 #include <dhcp/option_int.h>
 #include <dhcp/option4_addrlst.h>
 #include <dhcp/option6_addrlst.h>