]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
i3c: master: svc: Flush FIFO before sending Dynamic Address Assignment(DAA)
authorFrank Li <Frank.Li@nxp.com>
Wed, 29 Jan 2025 16:22:50 +0000 (11:22 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 May 2025 09:13:14 +0000 (11:13 +0200)
[ Upstream commit a892ee4cf22a50e1d6988d0464a9a421f3e5db2f ]

Ensure the FIFO is empty before issuing the DAA command to prevent
incorrect command data from being sent. Align with other data transfers,
such as svc_i3c_master_start_xfer_locked(), which flushes the FIFO before
sending a command.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/r/20250129162250.3629189-1-Frank.Li@nxp.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/i3c/master/svc-i3c-master.c

index a18fe62962b0cddce51d13d2ee6deae5a6c5d854..2cf2c567f89316d4bc4ffe0f874138aae0a9c139 100644 (file)
@@ -899,6 +899,8 @@ static int svc_i3c_master_do_daa_locked(struct svc_i3c_master *master,
        u32 reg;
        int ret, i;
 
+       svc_i3c_master_flush_fifo(master);
+
        while (true) {
                /* clean SVC_I3C_MINT_IBIWON w1c bits */
                writel(SVC_I3C_MINT_IBIWON, master->regs + SVC_I3C_MSTATUS);