]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
powercap: intel_rapl: Change an error pointer to NULL
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 23 Aug 2024 12:51:36 +0000 (15:51 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 30 Sep 2024 14:31:09 +0000 (16:31 +0200)
commit 6b08b4ee5e60d8789aeb87250f718ef14bebb90e upstream.

The rapl_find_package_domain_cpuslocked() function is supposed to
return NULL on error.

This new error patch returns ERR_PTR(-EINVAL) but none of the callers
check for that so it would lead to an Oops.

Fixes: 26096aed255f ("powercap/intel_rapl: Fix the energy-pkg event for AMD CPUs")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/fa719c6a-8d3b-4cca-9b43-bcd477ff6655@stanley.mountain
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/powercap/intel_rapl_common.c

index 5a6d05bf847cebaeadab63b57a820215cdcc68de..7c0cea2c828d99a391050e44356e76e7caf80654 100644 (file)
@@ -2156,7 +2156,7 @@ struct rapl_package *rapl_find_package_domain_cpuslocked(int id, struct rapl_if_
                      topology_physical_package_id(id) : topology_logical_die_id(id);
                if (uid < 0) {
                        pr_err("topology_logical_(package/die)_id() returned a negative value");
-                       return ERR_PTR(-EINVAL);
+                       return NULL;
                }
        }
        else