]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
firmware: arm_scmi: Convert to SYSTEM_SLEEP_PM_OPS
authorArnd Bergmann <arnd@arndb.de>
Wed, 9 Jul 2025 07:01:01 +0000 (09:01 +0200)
committerSudeep Holla <sudeep.holla@arm.com>
Wed, 9 Jul 2025 09:49:58 +0000 (10:49 +0100)
The old SET_SYSTEM_SLEEP_PM_OPS() macro leads to a warning about an
unused function:

  |  drivers/firmware/arm_scmi/scmi_power_control.c:363:12: error:
  |  'scmi_system_power_resume' defined but not used [-Werror=unused-function]
  |         static int scmi_system_power_resume(struct device *dev)

The proper way to do this these days is to use SYSTEM_SLEEP_PM_OPS()
and pm_sleep_ptr().

Fixes: 9a0658d3991e ("firmware: arm_scmi: power_control: Ensure SCMI_SYSPOWER_IDLE is set early during resume")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Peng Fan <peng.fan@nxp.com>
Message-Id: <20250709070107.1388512-1-arnd@kernel.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
drivers/firmware/arm_scmi/scmi_power_control.c

index ab0cee0d4beca1cf6a146b339ce1b462bc91ff54..955736336061d28dfa37c95ba9e3230c188a60e7 100644 (file)
@@ -369,7 +369,7 @@ static int scmi_system_power_resume(struct device *dev)
 }
 
 static const struct dev_pm_ops scmi_system_power_pmops = {
-       SET_SYSTEM_SLEEP_PM_OPS(NULL, scmi_system_power_resume)
+       SYSTEM_SLEEP_PM_OPS(NULL, scmi_system_power_resume)
 };
 
 static const struct scmi_device_id scmi_id_table[] = {
@@ -380,7 +380,7 @@ MODULE_DEVICE_TABLE(scmi, scmi_id_table);
 
 static struct scmi_driver scmi_system_power_driver = {
        .driver = {
-               .pm = &scmi_system_power_pmops,
+               .pm = pm_sleep_ptr(&scmi_system_power_pmops),
        },
        .name = "scmi-system-power",
        .probe = scmi_syspower_probe,