]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
accel/amdxdna: Fix uninitialized return value
authorLizhi Hou <lizhi.hou@amd.com>
Fri, 24 Oct 2025 16:55:03 +0000 (09:55 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Dec 2025 13:02:36 +0000 (14:02 +0100)
[ Upstream commit 81233d5419cf20e4f5ef505882951616888a2ef9 ]

In aie2_get_hwctx_status() and aie2_query_ctx_status_array(), the
functions could return an uninitialized value in some cases. Update them
to always return 0. The amount of valid results is indicated by the
returned buffer_size, element_size, and num_element fields.

Fixes: 2f509fe6a42c ("accel/amdxdna: Add ioctl DRM_IOCTL_AMDXDNA_GET_ARRAY")
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
Link: https://patch.msgid.link/20251024165503.1548131-1-lizhi.hou@amd.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/accel/amdxdna/aie2_pci.c

index 6e39c769bb6d8f5abe6c5113a8fc88f051f19891..43f725e1a2d761dcaacebb1fd46fc6c149531478 100644 (file)
@@ -845,7 +845,7 @@ static int aie2_get_hwctx_status(struct amdxdna_client *client,
        }
 
        args->buffer_size -= (u32)(array_args.buffer - args->buffer);
-       return ret;
+       return 0;
 }
 
 static int aie2_get_info(struct amdxdna_client *client, struct amdxdna_drm_get_info *args)
@@ -920,7 +920,7 @@ static int aie2_query_ctx_status_array(struct amdxdna_client *client,
        args->num_element = (u32)((array_args.buffer - args->buffer) /
                                  args->element_size);
 
-       return ret;
+       return 0;
 }
 
 static int aie2_get_array(struct amdxdna_client *client,