]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
btrfs: remove out label in scrub_find_fill_first_stripe()
authorFilipe Manana <fdmanana@suse.com>
Tue, 20 Jan 2026 20:05:02 +0000 (20:05 +0000)
committerDavid Sterba <dsterba@suse.com>
Tue, 3 Feb 2026 06:56:22 +0000 (07:56 +0100)
There is no point in having the label since all it does is return the
value in the 'ret' variable. Instead make every goto return directly
and remove the label.

Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/scrub.c

index 0bd4aebe1687713e55077272292a02c5c6f43f70..2a64e2d50ced972e4a195e3b2fe657084860cd27 100644 (file)
@@ -1696,7 +1696,7 @@ static int scrub_find_fill_first_stripe(struct btrfs_block_group *bg,
                                     logical_len);
        /* Either error or not found. */
        if (ret)
-               goto out;
+               return ret;
        get_extent_info(extent_path, &extent_start, &extent_len, &extent_flags,
                        &extent_gen);
        if (extent_flags & BTRFS_EXTENT_FLAG_TREE_BLOCK)
@@ -1729,7 +1729,7 @@ static int scrub_find_fill_first_stripe(struct btrfs_block_group *bg,
                ret = find_first_extent_item(extent_root, extent_path, cur_logical,
                                             stripe_end - cur_logical + 1);
                if (ret < 0)
-                       goto out;
+                       return ret;
                if (ret > 0) {
                        ret = 0;
                        break;
@@ -1763,7 +1763,7 @@ static int scrub_find_fill_first_stripe(struct btrfs_block_group *bg,
                                                stripe->logical, stripe_end,
                                                stripe->csums, &csum_bitmap);
                if (ret < 0)
-                       goto out;
+                       return ret;
                if (ret > 0)
                        ret = 0;
 
@@ -1773,7 +1773,7 @@ static int scrub_find_fill_first_stripe(struct btrfs_block_group *bg,
                }
        }
        set_bit(SCRUB_STRIPE_FLAG_INITIALIZED, &stripe->state);
-out:
+
        return ret;
 }